Document eth_sign discontinuation #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview published: 1313-eth-sign-discontinuation |
|
Only thought is to try and add a reference to the associated MIP for this change. |
|
Preview published: 1313-eth-sign-discontinuation |
|
Added in a link for MIP-3, but the file is not ready due to autonumbering issues: https://github.com/MetaMask/metamask-improvement-proposals/blob/main/MIPs/mip-x.md. Once that file is updated to |
|
Preview published: 1313-eth-sign-discontinuation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
eth_signdescription to note that it is no longer supported.Issue(s) fixed
Fixes #1313
Preview
https://docs.metamask.io/1313-eth-sign-discontinuation/wallet/concepts/signing-methods/#eth_sign
Checklist
Complete this checklist before merging your PR: